From 65c3246ed36a2d4f857704b34d0ba160a3bc5f2f Mon Sep 17 00:00:00 2001
From: pppscn <35696959@qq.com>
Date: Wed, 28 Jun 2023 16:58:30 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E5=A4=8D=EF=BC=9Abark=E5=8A=A0?=
 =?UTF-8?q?=E5=AF=86=E6=8E=A8=E9=80=81=EF=BC=8C=E8=A7=A3=E5=AF=86=E5=A4=B1?=
 =?UTF-8?q?=E8=B4=A5=20#307=20#314?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../sms/forwarder/fragment/senders/BarkFragment.kt       | 9 ++++++---
 app/src/main/res/values-en/strings.xml                   | 7 ++++---
 app/src/main/res/values/strings.xml                      | 7 ++++---
 3 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/app/src/main/java/com/idormy/sms/forwarder/fragment/senders/BarkFragment.kt b/app/src/main/java/com/idormy/sms/forwarder/fragment/senders/BarkFragment.kt
index 64fda4ce..e28200dc 100644
--- a/app/src/main/java/com/idormy/sms/forwarder/fragment/senders/BarkFragment.kt
+++ b/app/src/main/java/com/idormy/sms/forwarder/fragment/senders/BarkFragment.kt
@@ -280,13 +280,16 @@ class BarkFragment : BaseFragment<FragmentSendersBarkBinding?>(), View.OnClickLi
         val title = binding!!.etTitleTemplate.text.toString().trim()
         val key = binding!!.etEncryptionKey.text.toString().trim()
         val iv = binding!!.etEncryptionIv.text.toString().trim()
-        if (transformation.startsWith("AES128") && (key.length != 16 || iv.length != 16)) {
+        if (transformation.startsWith("AES128") && key.length != 16) {
             throw Exception(getString(R.string.bark_encryption_key_error1))
-        } else if (transformation.startsWith("AES192") && (key.length != 24 || iv.length != 24)) {
+        } else if (transformation.startsWith("AES192") && key.length != 24) {
             throw Exception(getString(R.string.bark_encryption_key_error2))
-        } else if (transformation.startsWith("AES256") && (key.length != 32 || iv.length != 32)) {
+        } else if (transformation.startsWith("AES256") && key.length != 32) {
             throw Exception(getString(R.string.bark_encryption_key_error3))
         }
+        if (transformation.contains("CBC") && iv.length != 16) {
+            throw Exception(getString(R.string.bark_encryption_key_error4))
+        }
 
         return BarkSetting(server, group, icon, sound, badge, url, barkLevel, title, transformation, key, iv)
     }
diff --git a/app/src/main/res/values-en/strings.xml b/app/src/main/res/values-en/strings.xml
index ace6c6cd..d9c93259 100644
--- a/app/src/main/res/values-en/strings.xml
+++ b/app/src/main/res/values-en/strings.xml
@@ -735,9 +735,10 @@
     <string name="bark_encryption_iv">AES iv</string>
     <string name="bark_encryption_iv_tips">corresponding iv on bark</string>
     <string name="bark_encryption_key_regex" formatted="false" tools:ignore="TypographyDashes"><![CDATA[^[a-zA-Z0-9]{16}]]></string>
-    <string name="bark_encryption_key_error1">AES Key and iv must be 16 characters</string>
-    <string name="bark_encryption_key_error2">AES Key and iv must be 24 characters</string>
-    <string name="bark_encryption_key_error3">AES Key and iv must be 32 characters</string>
+    <string name="bark_encryption_key_error1">AES Key must be 16 characters</string>
+    <string name="bark_encryption_key_error2">AES Key must be 24 characters</string>
+    <string name="bark_encryption_key_error3">AES Key must be 32 characters</string>
+    <string name="bark_encryption_key_error4">AES iv must be 16 characters</string>
 
     <string name="from_email_hint">Fill in the username before @</string>
     <string name="from_email_full_hint">Fill in the format: AAA@BBB.CCC</string>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index bc968ade..af90aa9a 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -736,9 +736,10 @@
     <string name="bark_encryption_iv">偏移向量</string>
     <string name="bark_encryption_iv_tips">对应bark上的iv</string>
     <string name="bark_encryption_key_regex" formatted="false" tools:ignore="TypographyDashes"><![CDATA[^([a-zA-Z0-9]{16})? $]]></string>
-    <string name="bark_encryption_key_error1">加密密钥和偏移向量都必须是16位</string>
-    <string name="bark_encryption_key_error2">加密密钥和偏移向量都必须是24位</string>
-    <string name="bark_encryption_key_error3">加密密钥和偏移向量都必须是32位</string>
+    <string name="bark_encryption_key_error1">加密密钥必须是16位</string>
+    <string name="bark_encryption_key_error2">加密密钥必须是24位</string>
+    <string name="bark_encryption_key_error3">加密密钥必须是32位</string>
+    <string name="bark_encryption_key_error4">偏移向量必须是16位</string>
 
     <string name="from_email_hint">填写 @ 前面的用户名</string>
     <string name="from_email_full_hint">填写格式: AAA@BBB.CCC</string>